This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Support for regarding flaky tests failures as non-fatal #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the crypto test is non-deterministic, and can be fixed with a merge of v0.10 into v0.12 The dns test needs to be improved to allow for both error codes But I do support in principle the premise of marking tests as potentially flakey |
|
Thanks for the clarification. Of course, the idea is to update the status file once the tests get fixed. |
Adding --flaky-tests option, to allow regarding flaky tests failures as non-fatal. Currently only observed by the TapProgressIndicator, which will add a # TODO directive to tests classified as flaky. According to the TAP specification, the test harness is supposed to treat failures that have a # TODO directive as non-fatal.
|
Thank you, landed in 0674cba |
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Feb 12, 2015
rvagg
added a commit
to nodejs/node
that referenced
this pull request
Feb 16, 2015
Reverts nodejs/node-v0.x-archive#8689 PR-URL: #812 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
This is needed in preparation of some upcoming CI changes that will allow Jenkins to validate PRs more effectively.